Skip to content

rpk: modify CODEOWNER #24807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
r-vasquez merged 2 commits into from
Jan 14, 2025
Merged

rpk: modify CODEOWNER #24807

r-vasquez merged 2 commits into from
Jan 14, 2025

Conversation

@r-vasquez
Copy link
Contributor

@r-vasquez r-vasquez commented Jan 14, 2025 •
edited
Loading

Adds @redpanda-data/ux-rpk as a codeowner for rpk changes.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@r-vasquez r-vasquez requested a review from a team as a code owner January 14, 2025 21:05
@r-vasquez r-vasquez requested review from ivotron and removed request for a team January 14, 2025 21:05
@dotnwat
Copy link
Member

dotnwat commented Jan 14, 2025

This is marked for backport, but i'm curious: do such files in branches have any affect?

@ivotron
Copy link
Member

ivotron commented Jan 14, 2025

This is marked for backport, but i'm curious: do such files in branches have any affect?

afaik they don't

ivotron
ivotron previously approved these changes Jan 14, 2025
View reviewed changes
@r-vasquez r-vasquez force-pushed the modify-rpk-codeowner branch from 0bf7a03 to a8562b6 Compare January 14, 2025 21:52
@r-vasquez
Copy link
Contributor Author

r-vasquez commented Jan 14, 2025

[Force Push]: Forgot to remove Travis B..

ivotron
ivotron previously approved these changes Jan 14, 2025
View reviewed changes
@r-vasquez r-vasquez merged commit 05c4d1c into redpanda-data:dev Jan 14, 2025
3 checks passed
@r-vasquez
Copy link
Contributor Author

r-vasquez commented Jan 17, 2025

@ivotron @dotnwat I think it does matter.

We just had a backported PR: #24859 and it has all the previous reviewers. I'll backport this PR

@r-vasquez
Copy link
Contributor Author

r-vasquez commented Jan 17, 2025

/backport v24.3.x

@vbotbuildovich vbotbuildovich mentioned this pull request Jan 17, 2025
Merged
@r-vasquez r-vasquez deleted the modify-rpk-codeowner branch March 4, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ivotron ivotron ivotron approved these changes

Assignees

No one assigned

Labels

area/build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-vasquez @dotnwat @ivotron