Skip to content

k/fetch: fix selecting replica with highest high watermark #25005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmaslankaprv merged 1 commit into from
Feb 3, 2025
Merged

k/fetch: fix selecting replica with highest high watermark #25005

mmaslankaprv merged 1 commit into from
Feb 3, 2025

Conversation

@mmaslankaprv
Copy link
Member

@mmaslankaprv mmaslankaprv commented Feb 3, 2025 •
edited
Loading

Previously the code was missing resetting container when replica with larger high watermark was found leading to undefined behavior.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@mmaslankaprv
k/fetch: fix selecting replica with highest high watermark
e4a8730 
Previously the code was missing resetting container when replica with
larger high watermark was found leading to undefined behavior.

Signed-off-by: Michał Maślanka <michal@redpanda.com>
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 3, 2025

CI test results

test results on build#61507
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61507#0194cc84-4491-478b-b380-00ea67a7def6 FLAKY 1/3
rptest.tests.compaction_recovery_test.CompactionRecoveryTest.test_index_recovery ducktape https://buildkite.com/redpanda/redpanda/builds/61507#0194cc88-1b73-4b37-b11b-1806ee82d8da FLAKY 1/3
rptest.tests.datalake.compaction_test.CompactionGapsTest.test_translation_no_gaps.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/61507#0194cc88-1b71-45f4-8f8a-c14aa81a795f FLAKY 1/3
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=True.with_tiered_storage=True.with_iceberg=False.with_chunked_compaction=False.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/61507#0194cc88-1b71-45f4-8f8a-c14aa81a795f FLAKY 1/2

@mmaslankaprv mmaslankaprv merged commit da0af31 into redpanda-data:dev Feb 3, 2025
21 checks passed
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 3, 2025

/backport v24.3.x

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 3, 2025

/backport v24.2.x

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Feb 3, 2025

/backport v24.1.x

This was referenced Feb 3, 2025
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvartolomei nvartolomei nvartolomei approved these changes

Assignees

No one assigned

Labels

area/redpanda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmaslankaprv @vbotbuildovich @nvartolomei