Skip to content

kafka: validator for Iceberg topics and read replicas #25228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrwng merged 1 commit into from
Mar 1, 2025
Merged

kafka: validator for Iceberg topics and read replicas #25228

andrwng merged 1 commit into from
Mar 1, 2025
+90 −2

Conversation

@andrwng
Copy link
Contributor

@andrwng andrwng commented Mar 1, 2025

The story for Iceberg topics that are read replicas is not complete (e.g. what catalog to write to, how to use the correct schemas, what it means if/when we stream Kafka from parquet), so for now we explicitly disallow this.

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@andrwng
kafka: validator for Iceberg topics and read replicas
60d3b21 
The story for Iceberg topics that are read replicas is not complete
(e.g. what catalog to write to, how to use the correct schemas, what it
means if/when we stream Kafka from parquet), so for now we explicitly
disallow this.
dotnwat
dotnwat approved these changes Mar 1, 2025
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrwng andrwng enabled auto-merge March 1, 2025 02:29
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 1, 2025

CI test results

test results on build#62486
test_id test_kind job_url test_status passed
rptest.tests.datalake.compaction_test.CompactionTest.test_compaction.cloud_storage_type=CloudStorageType.S3.catalog_type=CatalogType.REST_JDBC ducktape https://buildkite.com/redpanda/redpanda/builds/62486#01954f6a-e76c-47ec-b742-0b114588342c FLAKY 1/2
rptest.tests.log_segment_ms_test.SegmentMsTest.test_segment_rolling.use_alter_cfg=True.server_cfg=60000.topic_cfg=120000 ducktape https://buildkite.com/redpanda/redpanda/builds/62486#01954f7e-c2c5-4d79-9cec-77f799b915e1 FLAKY 1/2
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/62486#01954f6a-e76d-428a-a435-0fd524dd6ea5 FLAKY 1/2

@andrwng andrwng merged commit 01bc523 into redpanda-data:dev Mar 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotnwat dotnwat dotnwat approved these changes

@nvartolomei nvartolomei Awaiting requested review from nvartolomei

@mmaslankaprv mmaslankaprv Awaiting requested review from mmaslankaprv

Assignees

No one assigned

Labels

area/redpanda

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrwng @vbotbuildovich @dotnwat