Skip to content

[CORE-9073] rptest: deflake log_compaction_test #25369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
WillemKauf merged 1 commit into from
Mar 15, 2025
Merged

[CORE-9073] rptest: deflake log_compaction_test #25369

WillemKauf merged 1 commit into from
Mar 15, 2025

Conversation

@WillemKauf
Copy link
Contributor

@WillemKauf WillemKauf commented Mar 13, 2025 •
edited
Loading

This assertion on dirty bytes could race with a segment roll.

Turn the dirty bytes assert into a wait_until(), and remove some asserts that were less pertinent to ensuring compaction is complete.

Also fixes https://redpandadata.atlassian.net/issues/CORE-9091

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v24.3.x
  • v24.2.x
  • v24.1.x

Release Notes

  • none

@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 14, 2025 •
edited
Loading

CI test results

test results on build#63089
test_id test_kind job_url test_status passed
rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=.cancellation.dir.in.stage.preparing.use_alias.True ducktape https://buildkite.com/redpanda/redpanda/builds/63089#019591af-800c-40cd-b9cf-830d9be26254 FLAKY 1/2
rptest.tests.datalake.rest_catalog_connection_test.RestCatalogConnectionTest.test_redpanda_connection_to_rest_catalog.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/63089#019591af-800b-4a57-af9b-78ddecd31e75 FLAKY 1/2
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/63089#019591b1-e8a2-4f41-86bb-a6901da7c450 FLAKY 1/3
test results on build#63167
test_id test_kind job_url test_status passed
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/63167#01959619-024b-4ec5-8f92-d75264747ec4 FLAKY 1/2
rptest.tests.compaction_recovery_test.CompactionRecoveryUpgradeTest.test_index_recovery_after_upgrade ducktape https://buildkite.com/redpanda/redpanda/builds/63167#0195962d-6abe-4e35-8f64-b54d0f754d0d FLAKY 1/2
rptest.tests.data_migrations_api_test.DataMigrationsApiTest.test_migrated_topic_data_integrity.transfer_leadership=True.params=.cancellation.dir.in.stage.preparing.use_alias.True ducktape https://buildkite.com/redpanda/redpanda/builds/63167#0195962d-6abf-49b6-8e35-addd4e7d2295 FLAKY 1/2
rptest.tests.partition_movement_test.SIPartitionMovementTest.test_shadow_indexing.num_to_upgrade=0.cloud_storage_type=CloudStorageType.S3 ducktape https://buildkite.com/redpanda/redpanda/builds/63167#01959619-0249-4750-990d-ff2ef9e324a7 FLAKY 1/2
rptest.tests.random_node_operations_test.RandomNodeOperationsTest.test_node_operations.enable_failures=True.mixed_versions=False.with_tiered_storage=False.with_iceberg=False.with_chunked_compaction=True.cloud_storage_type=CloudStorageType.ABS ducktape https://buildkite.com/redpanda/redpanda/builds/63167#01959619-024a-4a49-910d-11a45aa602dc FLAKY 1/2
rptest.tests.scaling_up_test.ScalingUpTest.test_scaling_up_with_recovered_topic ducktape https://buildkite.com/redpanda/redpanda/builds/63167#01959619-0249-4750-990d-ff2ef9e324a7 FLAKY 1/5

@WillemKauf
Copy link
Contributor Author

WillemKauf commented Mar 14, 2025

/ci-repeat 10
skip-redpanda-build
skip-units
dt-repeat=20
tests/rptest/tests/log_compaction_test.py

@WillemKauf
Copy link
Contributor Author

WillemKauf commented Mar 14, 2025

No flakes in Build #63103

@WillemKauf WillemKauf enabled auto-merge March 14, 2025 03:30
@WillemKauf WillemKauf requested a review from andrwng March 14, 2025 03:30
@WillemKauf
rptest: deflake log_compaction_test
7a310b8 
This could race with a segment roll.

Turn the `assert` into a `wait_until()`, and remove some asserts
that were less pertinent to ensuring compaction is complete.
@WillemKauf WillemKauf force-pushed the log_compaction_deflake_for_the_final_time_for_sure branch from 250fd6d to 7a310b8 Compare March 14, 2025 18:02
@WillemKauf WillemKauf merged commit c0e1deb into redpanda-data:dev Mar 15, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrwng andrwng andrwng approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WillemKauf @vbotbuildovich @andrwng