Skip to content

add await for cacheAllCSFFiles explicitly #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shiyuu33 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add await for cacheAllCSFFiles explicitly #880

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/storycrawler/src/browser/stories-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,18 +77,17 @@ export class StoriesBrowser extends BaseBrowser {
timeout: 60_000,
},
);
await this.page.waitForTimeout(500);
await this.page.evaluate(() => {
await this.page.evaluate(async () => {
const api = (window as ExposedWindow).__STORYBOOK_CLIENT_API__ || (window as ExposedWindow).__STORYBOOK_PREVIEW__;
function isPreviewApi(api: API | PreviewAPI): api is PreviewAPI {
return (api as PreviewAPI).storyStoreValue !== undefined;
}
if (api === undefined) return;

if (isPreviewApi(api)) {
return api.storyStoreValue && api.storyStoreValue.cacheAllCSFFiles();
return api.storyStoreValue && (await api.storyStoreValue.cacheAllCSFFiles());
}
return api.storyStore?.cacheAllCSFFiles && api.storyStore.cacheAllCSFFiles();
return api.storyStore?.cacheAllCSFFiles && (await api.storyStore.cacheAllCSFFiles());
});
const result = await this.page.evaluate(() => {
function isPreviewApi(api: API | PreviewAPI): api is PreviewAPI {
Expand Down