Fix for https://github.com/rehooks/local-storage/issues/50 #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jharrilim
commented
Mar 26, 2020
| let [name, setName] = useLocalStorage(key, 'default value'); | ||
| React.useEffect(() => { | ||
| setName('key1 name'); | ||
| setTimeout(() => set('key2')); |
Collaborator
Author
There was a problem hiding this comment.
This setTimeout was causing problems, so it is now removed; the key is updated simply through a button click.
jharrilim
commented
Mar 26, 2020
|
|
||
| const [timEditAgeButton] = await findAllByTestId(allPeople[0]); | ||
|
|
||
| act(() => void fireEvent.click(timEditAgeButton)); |
Collaborator
Author
There was a problem hiding this comment.
act not needed for fireEvent
jharrilim
commented
Mar 26, 2020
| export function useLocalStorage<TValue = string>( | ||
| key: string, | ||
| initialValue?: TValue | ||
| ): [TValue | null, Dispatch<TValue>, Dispatch<void>] { |
Collaborator
Author
There was a problem hiding this comment.
return type inferred from the chosen overload
iamsolankiamit
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also refactored a test that was causing a warning
#50