Skip to content

Conversation

@FrancisMurillo
Copy link

This is my fix for the infinite loop when using f-uniquify-alist with projectile-current-project-dirs or #62 .

I simply made a wrapper for f-filename when the path has an separator at the end it also adds it.

@coveralls
Copy link

coveralls commented Aug 3, 2016

Coverage Status

Coverage increased (+0.05%) to 97.525% when pulling 0fbc972 on FrancisMurillo:uniquify-fix into de85171 on rejeep:master.

@FrancisMurillo FrancisMurillo changed the title Fix =f-uniquify-alist= infinite loop with =projectile-current-project… Fix f-uniquify-alist infinite loop with `projectile-current-project… Aug 4, 2016
@rejeep
Copy link
Owner

rejeep commented Aug 10, 2016

@Fuco1 Would you mind taking a look at this since you added the original function? Otherwise I'll look in to it.

@Fuco1
Copy link
Contributor

Fuco1 commented Aug 10, 2016

@rejeep will do. Can you assign the issue to me? I use that to track the work. (not sure if it works outside the project though)

@rejeep
Copy link
Owner

rejeep commented Aug 10, 2016

@Fuco1 sorry, not possible to assign you

@Fuco1
Copy link
Contributor

Fuco1 commented Mar 1, 2018

I run into this problem now. I think it would be valuable to have a function which always returns the last component as it is, so /foo/bar/baz -> baz and /foo/bar/baz/ -> baz/. We can then use that instead of the wrapper here (which essentially is that function).

We can call it f-last-component or something like that.

@Fuco1 Fuco1 mentioned this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants