backup: fix handling of files with type irregular #5057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d02b9b9 to
15fa98a
Compare
|
I can confirm that this also "fixes" my snapshots, in the sense that it deletes the irregular files from the snapshot(s). However, I have always had these irregular files, which are usually just symlinks (i.e. made by Cygwin or the Microsoft Store), and before 0.17.1, these were never a problem. Well, except for cluttering up the messages output when doing the backup. |
|
Btw I would really suggest removing the 0.17.1 downloads in favor of 0.17.0, as almost all Windows users will now start corrupting their backups, and it is quite silent until you run a |
restic cannot backup irregular files as those don't behave like normal files. Thus skip them with an error.
73db038 to
55c1500
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Since restic 0.17.1, files with type
irregularcould end up in a snapshot as the corresponding error was filtered due to #4977 . This PR fixes thebackupcommand and extendsrepair snapshotsto remove irregular files.Was the change previously discussed in an issue or on the forum?
Fixes https://forum.restic.net/t/errors-found-by-check-1-invalid-type-irregular-2-ciphertext-verification-failed/8447/2
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/that describes the changes for our users (see template).gofmton the code in all commits.