tests: fix acquisition translation problem #2823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `acq_account` API could return some translated messages. As these messages could be tested we need to ensure that no translation is done during unitests. Now we mock the translation function to return the same value than input value. Co-Authored-by: Renaud Michotte <renaud.michotte@gmail.com>
rerowep
approved these changes
Apr 7, 2022
BadrAly
approved these changes
Apr 7, 2022
Garfield-fr
approved these changes
Apr 7, 2022
lauren-d
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
acq_accountAPI could return some translated messages. As thesemessages could be tested we need to ensure that no translation is done
during unitests. Now we mock the translation function to return the same
value than input value.
Co-Authored-by: Renaud Michotte renaud.michotte@gmail.com
Code review check list