Skip to content

fix(collections): restrict adding items of selected libraries #3968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PascalRepond merged 1 commit into from
Oct 22, 2025
Merged

fix(collections): restrict adding items of selected libraries #3968

PascalRepond merged 1 commit into from
Oct 22, 2025

Conversation

@PascalRepond
Copy link
Contributor

@PascalRepond PascalRepond commented Oct 13, 2025 •
edited
Loading

  • Make the libraries field required in the collection resource.
  • Fix collection test data so that there are no items from the wrong
    libraries.
  • Fix collections fixtures setup so that the data is coherent.

@github-actions github-actions bot added f: data migration Data migration from a legacy system or a previous version dev: fixtures Fixtures data used for ils.test and ilsdev.test labels Oct 16, 2025
@coveralls
Copy link

coveralls commented Oct 16, 2025 •
edited
Loading

Coverage Status

coverage: 91.931% (+0.003%) from 91.928%
when pulling 5cf40f0 on PascalRepond:rep-coll-validation
into 57a10c3 on rero:staging.

rerowep
rerowep approved these changes Oct 21, 2025
View reviewed changes
@PascalRepond
fix(collections): restrict adding items of selected libraries
5cf40f0 
* Make the `libraries` field required in the `collection` resource.
* Fix collection test data so that there are no items from the wrong
libraries.
* Fix collections fixtures setup so that the data is coherent.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond merged commit 182442c into rero:staging Oct 22, 2025
4 checks passed
@PascalRepond PascalRepond deleted the rep-coll-validation branch October 22, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rerowep rerowep rerowep approved these changes

@Garfield-fr Garfield-fr Awaiting requested review from Garfield-fr

@jma jma Awaiting requested review from jma

Assignees

@PascalRepond PascalRepond

Labels

dev: fixtures Fixtures data used for ils.test and ilsdev.test f: data migration Data migration from a legacy system or a previous version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PascalRepond @coveralls @rerowep