Skip to content

Conversation

@jma
Copy link
Contributor

@jma jma commented Dec 2, 2025

  • Renames CIRCULATION_ACTIONS_VALIDATION into ITEM_CIRCULATION_ACTIONS_VALIDATION.
  • All circulation validation actions returns a reasons dictionaries.
  • Fixes dependencies.

Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch

@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Dec 2, 2025
@jma jma force-pushed the maj-can-request-codes branch 2 times, most recently from f592298 to f2b766a Compare December 2, 2025 15:31
@jma jma force-pushed the maj-can-request-codes branch 5 times, most recently from 1ce820f to 0eeb970 Compare December 3, 2025 09:15
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 3, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@coveralls
Copy link

coveralls commented Dec 3, 2025

Coverage Status

coverage: 91.948% (+0.006%) from 91.942%
when pulling 439eaf9 on jma:maj-can-request-codes
into e8824aa on rero:staging.

PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 3, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@jma jma requested review from PascalRepond and rerowep December 3, 2025 10:30
@jma jma marked this pull request as ready for review December 3, 2025 10:30
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 3, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 3, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to rero/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to PascalRepond/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond added a commit to rero/rero-ils-ui that referenced this pull request Dec 4, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
* Renames CIRCULATION_ACTIONS_VALIDATION to ITEM_CIRCULATION_ACTIONS_VALIDATION.
* All circulation validation actions return a dictionary of reasons.

Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch>
Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
@PascalRepond PascalRepond merged commit ced9e74 into rero:staging Dec 11, 2025
4 checks passed
PascalRepond added a commit to rero/rero-ils-ui that referenced this pull request Dec 11, 2025
… tooltip

* Only when the patron has reached the maximum number of
  active loans, fees, or requests, the request button is now displayed
  in the public UI but disabled with a tooltip explaining the reason.
  This allows patron to understand why they cannot place a request.
* Depends on rero/rero-ils#3992.

Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: circulation Concerns the circulation interface or backend f: user management

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants