-
Notifications
You must be signed in to change notification settings - Fork 30
refact(permissions): add codes to can request api #3992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f592298 to
f2b766a
Compare
1ce820f to
0eeb970
Compare
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 3, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 3, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 3, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 3, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
approved these changes
Dec 4, 2025
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
rerowep
approved these changes
Dec 4, 2025
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to rero/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to PascalRepond/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
added a commit
to rero/rero-ils-ui
that referenced
this pull request
Dec 4, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
PascalRepond
requested changes
Dec 4, 2025
* Renames CIRCULATION_ACTIONS_VALIDATION to ITEM_CIRCULATION_ACTIONS_VALIDATION. * All circulation validation actions return a dictionary of reasons. Co-Authored-by: Johnny Mariéthoz <Johnny.Mariethoz@rero.ch> Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
0eeb970 to
439eaf9
Compare
PascalRepond
approved these changes
Dec 11, 2025
PascalRepond
added a commit
to rero/rero-ils-ui
that referenced
this pull request
Dec 11, 2025
… tooltip * Only when the patron has reached the maximum number of active loans, fees, or requests, the request button is now displayed in the public UI but disabled with a tooltip explaining the reason. This allows patron to understand why they cannot place a request. * Depends on rero/rero-ils#3992. Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Johnny Mariéthoz Johnny.Mariethoz@rero.ch