feat: request permissions before actions requiring them #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check and request location permissions before Bluetooth scanning in onboarding - Request notification permissions when enabling background scanning - Check location permissions before enabling auto-unlock feature - Add user-friendly error messages for permission denials - Add translations for permission error messages (en, de, pi)
Contributor
Author
|
I'm not sure this actually happens in "prod" deployments but with the dev app I keep having the app attempt to scan or bond scooters but never asking for the permission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes permission handling so that permissions are requested before the specific actions that need them, rather than failing silently or at unexpected times.
Issues Fixed
Changes
Technical Details
Files Changed
lib/onboarding_screen.dart- Permission check before scooter searchlib/stats/settings_section.dart- Permission checks for background scan and auto-unlockassets/i18n/*.json- Added translation keys for permission error messagesTesting Checklist