Broken ia32 relocs and an unimportant submodule change. #357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is purely superficial, as the commit points at the shim-15.4 branch already, but some people have found it confusing. This fixes issue rhboot#356. Signed-off-by: Peter Jones <pjones@redhat.com>
Commit c6281c6 needs to have included a ". = ALIGN(4096)" directive before .reloc, but fails to do so. As a result, binutils, which does not care about the actual binary format's constraints in any way, does not enforce the section alignment, and it will not load. Signed-off-by: Peter Jones <pjones@redhat.com>
9 tasks
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.