csv: detect end of csv file correctly #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.sbat sections contain user supplied data. We should not assume that it is well formed. The last line feed might be missing or it might not be at the end of the file. Instead one or more \0 might follow. In parse_csv_data() variable 'line' is a pointer with a value between the values of 'data' and 'data_end'. There is no reason to check that it is non-zero after assigning it from 'data' as we already check 'data'. Instead at the beginning of the file and after each line we must check that we have not reached the end of the file marked by a '\0' character. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Data after a NUL byte should be ignored. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
|
By mistake in the original pull request I included a superfluous '#include <stdio.h>'. It is removed now. Thanks @xnox for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.sbat sections contain user supplied data. We should not assume that it is
well formed. The last line feed might be missing or it might not be at the
end of the file. Instead one or more \0 might follow.
In parse_csv_data() variable 'line' is a pointer with a value between
the values of 'data' and 'data_end'.
There is no reason to check that it is non-zero after assigning it
from 'data' as we already check 'data'.
Instead at the beginning of the file and after each line we must check that
we have not reached the end of the file marked by a '\0' character.