Refactor LiveOS installation to reuse existing mount point #6612
+65
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/kickstart-tests --testtype payload |
c7015e3 to
6f3dd6f
Compare
|
This PR is stale because it has been open 60 days with no activity. |
6f3dd6f to
6033bfe
Compare
Contributor
Author
|
/kickstart-tests --testtype payload |
Contributor
Author
|
/kickstart-tests --testtype smoke |
6033bfe to
025cfae
Compare
025cfae to
ecade40
Compare
ecade40 to
3a8f0c5
Compare
Contributor
Author
|
/kickstart-tests --testtype payload |
Contributor
Author
|
/kickstart-tests --testtype smoke |
3a8f0c5 to
d14fb74
Compare
Contributor
Author
|
/kickstart-tests --testtype smoke |
Eliminate duplicate mounting by reusing /run/rootfsbase instead of creating /run/install/sources/mount-0000-live_os_image. This simplifies the code and removes redundant filesystem operations during installation. The original implementation created a separate mount point to follow the same pattern as other sources (CDROM, NFS, HDD). However, LiveOS is a special case where /run/rootfsbase is already mounted by the live system and contains the same content. Creating a duplicate mount is redundant. Relevant: rhbz#2413622
d14fb74 to
2c484af
Compare
Contributor
Author
|
/kickstart-tests --testtype smoke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate duplicate mounting by reusing /run/rootfsbase instead of creating /run/install/sources/mount-0000-live_os_image. This simplifies the code and removes redundant filesystem operations during installation.