fix: ensure that branches are sorted #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rickstaa I think this is ready for review (then release). Thank-you for this github/action! |
Contributor
Author
|
This regression is likely due to
Workaround is to set the following before the checkout action. |
ameynert
added a commit
to fulcrumgenomics/fgsmk
that referenced
this pull request
Jan 27, 2025
…d unzipping artifacts before release
Toxicom
added a commit
to Toxicom/toxiui
that referenced
this pull request
Feb 5, 2025
Oh my god, thank you so much! This is exactly what fixed it for me. ❤️ |
|
My CI/CD pipeline was failing because of this upgrade of git. I was unable to deploy tags in production. Thanks a lot for the quick workaround! As mentioned, the git config command must me done before the first checkout. To make it clear for those stumbling on this issue, the workaround looks like this: steps:
# Step added as a workaround for https://github.com/rickstaa/action-contains-tag/pull/18
# TODO: bump version of action-contains-tag and remove this workaround step after PR above is merged
- name: Workaround regression action-contains-tag due to git update
run: git config --global remote.origin.followRemoteHEAD never
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Check if tag refers to a commit in main branch
uses: rickstaa/action-contains-tag@v1
with:
reference: 'main'
tag: ".... tag you want to check....." |
msto
added a commit
to fulcrumgenomics/prymer
that referenced
this pull request
Feb 13, 2025
## Summary Copies the fix referenced in rickstaa/action-contains-tag#18 and implemented in pybwa https://github.com/fulcrumgenomics/pybwa/blob/9193fb98fdebf63ed264fa08667b4dbbf79c796c/.github/workflows/publish_pybwa.yml#L16-L22
Contributor
Author
|
@rickstaa bump |
ameynert
added a commit
to fulcrumgenomics/fgsmk
that referenced
this pull request
Mar 14, 2025
…d unzipping artifacts before release
ameynert
added a commit
to fulcrumgenomics/fgsmk
that referenced
this pull request
Mar 14, 2025
…d unzipping artifacts before release
ameynert
added a commit
to fulcrumgenomics/fgsmk
that referenced
this pull request
Mar 31, 2025
…d unzipping artifacts before release
Contributor
Author
|
@rickstaa sorry to bother you, any chance you can look at this? |
Contributor
Author
|
Closing as no response from maintainer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases I have seen:
[action-contains-tag] Branch 'remotes/origin/HEAD -> origin/main' does not contain tag '1.4.2'.We see that the branch is incorrect (it should be
main). See log from my repo below, as well as this PRs own action (first and second commit here)example log