Run all JsComponent interactions asynchronously #1684
Merged
+39
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasherceg
approved these changes
Aug 2, 2023
Initialization, update and dispose of JsComponent is now executed in the next event loop cycle - i.e. after all other knockout components have been initialized. The main reason for this is to NOT handle exceptions from the JS component and avoid crashing the entire page when one component fails to load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialization, update and dispose of JsComponent
is now executed in the next event loop cycle - i.e. after all other knockout components have been initialized. The main reason for this is to NOT handle
exceptions from the JS component and avoid
crashing the entire page when one component fails to load.