Skip to content

Bump grove version to v1.8.0 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amyfbrown wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump grove version to v1.8.0 #207

amyfbrown wants to merge 1 commit into from

Conversation

@amyfbrown
Copy link
Contributor

@amyfbrown amyfbrown commented Apr 29, 2019 •
edited
Loading

Bump the grove version to a new v1.x value so that pip install quantum-grove gives users a version that's pyQuil 2.0 compatible.

@amyfbrown amyfbrown self-assigned this Apr 29, 2019
@msohaibalam
Copy link

msohaibalam commented May 1, 2019

Would it be a problem that we're bumping the version down in this case?

@amyfbrown
Copy link
Contributor Author

amyfbrown commented May 1, 2019

@msohaibalam, I agree that it's odd to go from v2.0.0b0 to v1.x. Can we delete the v2.0.0b0 pre-release tag and proceed with the v1.x tag? If not, we could consider releasing v2.0.0 without a beta flag in the patch version. The changes are backwards-incompatible, so it might make more sense to bump the major version number.

@notmgsk
Copy link

notmgsk commented Jul 10, 2019

I don't think it should matter than we're changing the version down from v2.0.0b0 since that tag is not seen by pip or conda (as far as I can tell).

@amyfbrown
Copy link
Contributor Author

amyfbrown commented Jul 10, 2019

@notmgsk, it looks like 2.0.0b0 is listed as a pre-release on pypi.

@notmgsk
Copy link

notmgsk commented Jul 10, 2019

@notmgsk, it looks like 2.0.0b0 is listed as a pre-release on pypi.

Even so, does it really matter? Pre-release should roughly mean "don't depend on this"

notmgsk
notmgsk approved these changes Jul 10, 2019
View reviewed changes
Copy link

@notmgsk notmgsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring the semaphore weirdness. LG2M.

@notmgsk notmgsk mentioned this pull request Aug 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karalekas karalekas Awaiting requested review from karalekas

@msohaibalam msohaibalam Awaiting requested review from msohaibalam

1 more reviewer

@notmgsk notmgsk notmgsk approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@amyfbrown amyfbrown

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amyfbrown @msohaibalam @notmgsk