feat: restrict dependency versions #1841
Conversation
|
| Branch | 1840-narrow-dependency-specs |
| Testbed | ci-runner-linux |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | seconds (s) |
|---|---|---|
| test/benchmarks/test_program.py::test_copy_everything_except_instructions | 📈 view plot | 10.41 s |
| test/benchmarks/test_program.py::test_instructions | 📈 view plot | 4.05 s |
| test/benchmarks/test_program.py::test_iteration | 📈 view plot | 4.06 s |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
65cace3 to
1071f2e
Compare
There CI failures running doctest due to a missing transitive dependency. It appears the root-cause is an outdated version of Poetry, so this commit updates the version that will be installed.
|
|
||
| [tool.poetry.dependencies] | ||
| python = "^3.9,<4" | ||
| python = "^3.9,<3.13" |
There was a problem hiding this comment.
Will we loosen this bound once we've resolved the various breaking changes with PyO3? It may be helpful to link a ticket, perhaps this one, in that case.
There was a problem hiding this comment.
I believe this will cause major downstream problems, is this totally necessary.
There was a problem hiding this comment.
Yes, definitely -- that's an excellent idea. I'm going to link to this PyQuil one instead.
For future readers: To enable support for Python 3.13+ in PyQuil, we're first adding support in the lower-level quil package. It's about to release a new version, but it has many breaking changes, so we need to ensure new PyQuil installs don't accidentally pull it in -- that's what this PR is for. Once PyQuil is updated to work with the new quil, we'll be able to release a new version compatible with Python 3.13+.
There is a very early draft PR and corresponding wheels that are compatible with the newest quil, but that branch was made to help test quil, so it includes breaking changes that aren't necessarily required for the next PyQuil release. Still, we are moving closer to this goal!
This updates the dependency specification for pre-1.0 packages that use semantic versioning. It additionally restricts the upper bound on the Python version, since PyQuil isn't currently compatible with Python 3.13, leading to installation errors.
I've set the upper bound to the latest release of the packages in question, and confirmed the unit tests pass with those newest versions, but it's plausible a different specifier would be more appropriate.
Closes: #1840