Skip to content

Update reStream.sh #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rien merged 2 commits into from
Jan 9, 2024
Merged

Update reStream.sh #100

rien merged 2 commits into from
Jan 9, 2024

Conversation

@nicksen782
Copy link
Contributor

@nicksen782 nicksen782 commented Nov 14, 2023

Can now detect if the Remarkable version is older than 2023-10-02. Versions ahead of this date use a different format for the video settings.

@nicksen782
Update reStream.sh
ed20ef6 
Can now detect if the Remarkable version is older than 2023-10-02. Versions ahead of this date use a different format for the video settings.
Eeems
Eeems reviewed Nov 14, 2023
View reviewed changes
Eeems
Eeems reviewed Nov 14, 2023
View reviewed changes
Eeems
Eeems reviewed Nov 14, 2023
View reviewed changes
Eeems
Eeems reviewed Nov 14, 2023
View reviewed changes
@nicksen782
Copy link
Contributor Author

nicksen782 commented Nov 14, 2023

Now checks if the remarkable version is greater or equal to 3.7.0.1930.

@nicksen782
Copy link
Contributor Author

nicksen782 commented Nov 27, 2023

Is this sufficient or would you like additional changes?

@nicksen782
Copy link
Contributor Author

nicksen782 commented Dec 14, 2023

Are these changes sufficient? Would you like me to change anything else?

@Eeems
Copy link

Eeems commented Dec 14, 2023

@rien

@rien rien merged commit d965933 into rien:main Jan 9, 2024
This was referenced Jan 9, 2024
Closed
Closed
Closed
Closed
Closed
@itay-grudev
Copy link
Contributor

itay-grudev commented Jan 9, 2024 •
edited
Loading

@rien The solution on main is still kind of dark and low contrast, but I found another way to rescale the colours and correct the defect directly. I'll submit a PR in 10min.

Update - See #101

@itay-grudev itay-grudev mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Eeems Eeems Eeems left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicksen782 @Eeems @itay-grudev @rien