Skip to content

Reference External mappings #1890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
latonz merged 51 commits into from
Oct 7, 2025
Merged

Reference External mappings #1890

latonz merged 51 commits into from
Oct 7, 2025

Conversation

@faddiv
Copy link
Contributor

@faddiv faddiv commented Jul 22, 2025 •
edited
Loading

Reference External mappings

Description

Implements external mapping for static methods and instance methods through field reference.

Fixes #1856

Checklist

  • The existing code style is followed
  • The commit message follows our guidelines
  • Performed a self-review of my code
  • Hard-to-understand areas of my code are commented
  • The documentation is updated (as applicable)
  • Unit tests are added/updated
  • Integration tests are added/updated (as applicable, especially if feature/bug depends on roslyn or framework version in use)

faddiv
faddiv commented Jul 22, 2025
View reviewed changes
faddiv
faddiv commented Jul 24, 2025
View reviewed changes
faddiv
faddiv commented Jul 26, 2025
View reviewed changes
@faddiv faddiv marked this pull request as ready for review July 26, 2025 06:43
@latonz latonz added the enhancement New feature or request label Jul 28, 2025
latonz
latonz requested changes Jul 28, 2025
View reviewed changes
Copy link
Contributor

@latonz latonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!

faddiv
faddiv commented Aug 2, 2025
View reviewed changes
@faddiv faddiv force-pushed the feature/reference-external-mappings branch from 923225b to b0c0a39 Compare August 31, 2025 19:43
faddiv
faddiv commented Sep 6, 2025
View reviewed changes
@faddiv faddiv requested a review from latonz September 6, 2025 11:28
@faddiv
Copy link
Contributor Author

faddiv commented Sep 17, 2025

Hi @latonz ,
I thought that the re-request review would be enough to request your input. (You requested this previously.)
If not, how can I notice you? Currently, I have the questions above, which are needed so I can continue the work.

@latonz
Copy link
Contributor

latonz commented Sep 18, 2025

Thanks for the updates, and sorry for the delay, this kept slipping down my to-do list. I’ll do a full review once you’ve addressed this.

faddiv
faddiv commented Sep 30, 2025
View reviewed changes
@faddiv
Copy link
Contributor Author

faddiv commented Sep 30, 2025

Hi @latonz,
I'm done with everything.

faddiv
faddiv commented Sep 30, 2025
View reviewed changes
latonz
latonz previously approved these changes Oct 7, 2025
View reviewed changes
@latonz latonz merged commit deadab2 into riok:main Oct 7, 2025
19 checks passed
@latonz
Copy link
Contributor

latonz commented Oct 7, 2025

Thank you for this contribution!

@faddiv faddiv mentioned this pull request Oct 12, 2025
Closed
@latonz latonz mentioned this pull request Dec 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@latonz latonz latonz left review comments

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reference external mappings

2 participants

@faddiv @latonz