This repository was archived by the owner on Feb 24, 2020. It is now read-only.
lib: don't error out if we can't get the app exit code #3800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucab
suggested changes
Sep 19, 2017
| // after a pod dies) let's continue instead of erroring out, the exit code | ||
| // will be -1 and we'll let callers handle it. | ||
| code, _ := pod.AppExitCode(app.Name) | ||
| exitCode := int32(code) |
Member
There was a problem hiding this comment.
Exit codes should be in the 0-255 range though (u8). I've no idea if this would confuse any consumer, but it looks a bit sketchy. I suggest to handle the error instead and fallback to either 1 (generic error code) or 254 (rkt error code).
Member
Author
There was a problem hiding this comment.
That sounds reasonable. Thanks!
Member
Author
There was a problem hiding this comment.
I went with a generic error code since we don't know what really happened.
This can happen if the pod dies but we don't have time to register the app exit code. Let's be more flexible here and continue even then.
bb9a61d to
374d8ba
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen if the pod dies but we don't have time to register
the app exit code.
Let's be more flexible here and continue even then.