Skip to content
This repository was archived by the owner on Feb 24, 2020. It is now read-only.

scripts/build-pkgs: use RPM file dependency for shadow tools#3904

Merged
lucab merged 1 commit into
rkt:masterfrom
hwoarang:flexible-shadow-rpm-dep
Mar 8, 2018
Merged

scripts/build-pkgs: use RPM file dependency for shadow tools#3904
lucab merged 1 commit into
rkt:masterfrom
hwoarang:flexible-shadow-rpm-dep

Conversation

@hwoarang

@hwoarang hwoarang commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Different RPM distributions use different packages to collect the
various tools from the 'shadow' package so we could use the path
from one of these tools in order to allow the rkt package to be used
in more RPM distributions.

Fixes: #3908

Different RPM distributions use different packages to collect the
various tools from the 'shadow' package so we could use the path
from one of these tools in order to allow the rkt package to be used
in more RPM distributions.
@squeed

squeed commented Feb 12, 2018

Copy link
Copy Markdown
Contributor

Oh, good catch.

@lucab lucab added this to the 1.30.0 milestone Mar 8, 2018
@lucab lucab changed the title scripts: pkg: build-pkgs.sh: Use RPM file dependency for shadow tools scripts/build-pkgs: Use RPM file dependency for shadow tools Mar 8, 2018
@lucab lucab changed the title scripts/build-pkgs: Use RPM file dependency for shadow tools scripts/build-pkgs: use RPM file dependency for shadow tools Mar 8, 2018

@lucab lucab left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucab lucab merged commit 8b64477 into rkt:master Mar 8, 2018
hwoarang pushed a commit to hwoarang/kubespray that referenced this pull request Apr 11, 2018
The RPM file that's provided by upstream can be used for SUSE
distributions as well. Moreover we simplify the playbook to use
the 'package' module to install packages across different distros.

Link: rkt/rkt#3904
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants