fix: remove hardcoded secrets from embedded config and add JWT algorithm verification#727
Open
saaa99999999 wants to merge 1 commit into
Open
fix: remove hardcoded secrets from embedded config and add JWT algorithm verification#727saaa99999999 wants to merge 1 commit into
saaa99999999 wants to merge 1 commit into
Conversation
…thm verification Replace hardcoded JWT secret, DB passwords, OSS credentials, and API keys in embedded config.yaml with empty strings. Add JWT secret validation at startup. Add HMAC algorithm verification in ParseToken to prevent JWT algorithm confusion attacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The embedded
config.yamlshipped in every binary contains hardcoded production credentials that are identical across all deployments:Additionally,
ParseToken()does not verify the JWT signing algorithm.Changes
internal/conf/config.yaml: Replaced all hardcoded secrets with empty stringsinternal/conf/conf.go: Added startup validation that exits with error if JWT Secret is not configuredpkg/app/jwt.go: Added HMAC algorithm verification inParseToken()callbackTest plan
🤖 Generated with Claude Code