Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rockstor/rockstor-core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5.0.3-0
Choose a base ref
...
head repository: rockstor/rockstor-core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5.0.4-0
Choose a head ref
  • 14 commits
  • 10 files changed
  • 4 contributors

Commits on Aug 20, 2023

  1. Migrate to New Middleware style #2662

    In Django 1.10, the old `MIDDLEWARE_CLASSES` style was deprecated and we
    should now use `MIDDLEWARE` setting.
    
    This commit includes this move and takes advantage of the new
    MiddlewareMixin to help provide compatibility for our custom middleware.
    FroggyFlox committed Aug 20, 2023
    Configuration menu
    Copy the full SHA
    e17feca View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Use user.is_authenticated as an attribute #2664

    Prior to Django 1.10, user.is_authenticated() was a method.
    Since then, compatibility was ensured but this compatibility will be
    removed in Django 2.0. This commit thus moves to using the
    user.is_authenticated attribute instead.
    FroggyFlox committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    f84771e View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Merge pull request #2663 from FroggyFlox/2662-Update-Middlewares-styles

    Migrate to New Middleware style #2662
    phillxnet authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c0f7db9 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2665 from FroggyFlox/2664-models.User.is_authenti…

    …cated()-will-be-deprecated-in-Django-2.0
    
    Use user.is_authenticated as an attribute #2664
    phillxnet authored Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b4128ad View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Configuration menu
    Copy the full SHA
    52f428c View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    a6e6187 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Explicitly set REALM when querying workgroup #2671

    During Active Directory activation, we query the Workgroup information
    from the AD server using `net ads workgroup`. This normally gets its
    parameters from `smb.conf` but we need here to explicitly give the
    required server information at the command call given we usually work
    with an empty `smb.conf` file at this stage.
    
    This commit switches from using the `-S|--server` flag to the `--realm`
    flag as that has proven more robust.
    FroggyFlox committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    7b1057c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Catch DBusException to not throw error on LDAP group lookup #2673

    We currently use InfoPipe to fetch the groupname of domain users. While
    this works for Active Directory users, this can fail for LDAP users if
    these do not belong to a posixAccount group.
    
    This commit simply catches the DBusException thrown in such cases and
    logs the event (DEBUG level). The result is a groupname of "null".
    
    Also includes:
    - minor Black formatting
    - type hints
    - import optimization
    - minor copyright updates
    FroggyFlox committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    c997dcd View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Merge pull request #2667 from FroggyFlox/2666-use_for_related_fields-…

    …is-deprecated-in-Django-2.0
    
    Set `Meta.base_manager_name` on 'storageadmin.Disk' #2666
    phillxnet authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a80fdeb View commit details
    Browse the repository at this point in the history
  2. Merge pull request #2670 from Hooverdan96/2668_distro_version

    surface Distro Version to breadcrumb bar #2668
    phillxnet authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    141ecad View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2672 from FroggyFlox/2671-Failure-to-automaticall…

    …y-update-configure-Samba-workgroup-during-AD-service-activation
    
    Explicitly set REALM when querying workgroup #2671
    phillxnet authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    e822e65 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #2674 from FroggyFlox/2673_LDAP-failure-to-account…

    …-for-non-posix-groups
    
    Catch DBusException to not throw error on LDAP group lookup #2673
    phillxnet authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    410ab55 View commit details
    Browse the repository at this point in the history
  5. Bump versions to a 5.0.4 base (Testing) - testing branch #2675

    pyproject.toml build.sh
    phillxnet committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    157344d View commit details
    Browse the repository at this point in the history
  6. Merge pull request #2676 from phillxnet/2675-Bump-versions-to-a-5.0.4…

    …-base-(Testing)-testing-branch
    
    Bump versions to a 5.0.4 base (Testing) - testing branch #2675
    phillxnet authored Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a2d7594 View commit details
    Browse the repository at this point in the history
Loading