Catch DBusException to not throw error on LDAP group lookup #2673 #2674
Conversation
…2673 We currently use InfoPipe to fetch the groupname of domain users. While this works for Active Directory users, this can fail for LDAP users if these do not belong to a posixAccount group. This commit simply catches the DBusException thrown in such cases and logs the event (DEBUG level). The result is a groupname of "null". Also includes: - minor Black formatting - type hints - import optimization - minor copyright updates
|
@FroggyFlox this looks good to me. It was certainly a non-trivial problem that was posted in the forum... |
|
@FroggyFlox @Hooverdan96 My apologies for the delay in merging of late, I'll find time shortly to address the backlog and do a fresh testing release. We are still relatively early in testing so we can field test these more recent additions within the testing channel: especially given their nature of required infrastructure. @FroggyFlox Thanks for seeing to this one so rapidly. |
There was a problem hiding this comment.
@FroggyFlox This was a great find: thanks for your continued improvements in this area (and others) :).
Again only a cursory review given no infrastructure to test this against. But given my last comments I think this should be OK.
We again have a successful TW rpm build here.
Fixes #2673
@phillxnet, @Hooverdan96: ready for review.
We currently use InfoPipe to fetch the groupname of domain users. While this works for Active Directory users, this can fail for LDAP users if these do not belong to a posixAccount group. See #2673 and the forum thread linked therein for all details.
This pull request simply catches the DBusException thrown in such cases and logs the event (DEBUG level). The result is a groupname of "null".
Also includes:
Functional testing
Join Rockstor to a LDAP server set with 2 user accounts:
gidNumberof 100: this gid exists in Rockstor so the groupname should be picked up.gidNumberof 10000: this gid does NOT exist in Rockstor and does not correspond to a posixAccount group in the LDAP server so Rockstor cannot look up that group's name.Going to the "Users" page, we do not have an error and we now see both users:
Unit testing