Py3.6 ModuleNotFoundError: No module named 'mock' - tests #2575 #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imports changed to reflect now build-in unittest.mock. # Includes copywrite changes: - Added missing copyright. - Majority in affected directories updated re date https.
|
@FroggyFlox I have partially addressed your prior issue re style of import on the last pr. Given this pr re-enabled around 200 tests and we were down to 58 actually running I'm going to merge without review as we then have almost all of our test suite back with only likely stylistic issues on the import. Plus there are not issues of the issued error remaining. If we end up using mock/patch elsewhere (via old now removed import) we can approach that issue in it's own pull request. |
30 tasks
|
Thanks a lot for taking care of such a tedious work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports changed to reflect now build-in unittest.mock.
Fixes #2575
Includes copywrite changes:
Testing
Post the proposed changes we no longer have any test failing due to the issue/pr title: