Improve OS independence re unit tests #2633 #2637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add missing mock in test_commands.py re enable_quota() & get_unlocked_luks_containers_uuids(). - add missing mock in test_email_client.py re update_master(). - add missing mock in test_samba.py re refresh_smb_discovery(). - add missing mocks in test_snmp.py re systemd interaction. - add missing mock in test_network.py re nmcli call. - add missing mock in test_snapshot.py re refresh_nfs_exports. - add missing mock in test_config_backup.py re file expectation. - add missing mock in test_disks.py re dmsetup call. - revise & update test_user.py re fixtures use. Re-enables a number of remarked-out user tests awaiting this revision. Improves readability, scope, and specificity re test names.
|
The testing for this pull request is to be done against the rockstor-rpmbuid work done against issue: "Improve BuildRequires use": rockstor/rockstor-rpmbuild#28 As this pr is a spin-off from work in-progress done against the above issue which aims to reduce our BuildRequires: ergo the test improvements here that otherwise created false rpmbuild dependencies due to inappropriate OS sensitivity during test rurns. |
|
See the following rockstor-rpmbuild pull request comment re test builds including this patch to rockstor-core: We now expect the following output from a %check rpmbuild scriptlet: |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes improved instructions on running each test set for all test files modified.
Fixes #2633