Skip to content

Update django-pipeline to latest #2689 #2694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update django-pipeline to latest #2689 #2694

merged 1 commit into from
Oct 12, 2023

Conversation

@phillxnet
Copy link
Member

@phillxnet phillxnet commented Oct 12, 2023

Remove version pinning given we have now removed
the prior dual constraint re Python version and
Django version.

Fixes #2689

@phillxnet
Update django-pipeline to latest rockstor#2689
5a6abb2 
Remove version pinning given we have now removed
the prior dual constraint re Python version and
Django version.
@phillxnet
Copy link
Member Author

phillxnet commented Oct 12, 2023

Testing

An rpm was built successfully, so all tests passed, using a Leap 15.5/amd64 base; from the product of this PR. This RPM installed successfully with the expected zypper history log entries re static files creation e.g.:

...
# Post-processed 'storageadmin/css/style.css' as 'storageadmin/css/style.f4d53bb84d12.css'
# Post-processed 'rest_framework/css/bootstrap-theme.min.css' as 'rest_framework/css/bootstrap-theme.min.66b84a04375e.css'
# Post-processed 'rest_framework/css/bootstrap-tweaks.css' as 'rest_framework/css/bootstrap-tweaks.46ed116b0edd.css'
# Post-processed 'rest_framework/css/bootstrap.min.css' as 'rest_framework/css/bootstrap.min.77017a69879a.css'
# Post-processed 'rest_framework/css/default.css' as 'rest_framework/css/default.8d5591a6aabc.css'
# Post-processed 'rest_framework/css/font-awesome-4.0.3.css' as 'rest_framework/css/font-awesome-4.0.3.c1e1ea213abf.css'
# Post-processed 'rest_framework/css/prettify.css' as 'rest_framework/css/prettify.a987f72342ee.css'
# 
# 506 static files copied to '/opt/rockstor/static', 576 post-processed.
# 
# ROCKSTOR BUILD SCRIPT COMPLETED

The resulting install was setup via Web-UI and appeared as expected. A Web-UI development mode network disable-cache was also used to ensure the newly generated static files were those in play.

@phillxnet phillxnet marked this pull request as ready for review October 12, 2023 12:41
@phillxnet
Copy link
Member Author

phillxnet commented Oct 12, 2023

Popping this on in as looks to be fairly safe.

@phillxnet phillxnet merged commit b02daec into rockstor:testing Oct 12, 2023
@phillxnet phillxnet deleted the 2689-Update-django-pipeline-to-latest branch October 12, 2023 13:32
@phillxnet phillxnet mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phillxnet