Skip to content

Update Huey task queue library #2731 #2741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2023
Merged

Update Huey task queue library #2731 #2741

merged 1 commit into from
Nov 13, 2023

Conversation

@phillxnet
Copy link
Member

@phillxnet phillxnet commented Nov 11, 2023 •
edited
Loading

Remove prior pin of 2.3.0 and update to 2.5.0 via poetry update to recreate poetry.lock accordingly.

Fixes #2731

Testing

For functional testing see the following linked issue comment: #2731 (comment)

Test suite

We have on failing test:

======================================================================
FAIL: test_post_valid_balance_follow_through (rockstor.storageadmin.tests.test_pool_balance_huey.PoolBalanceTestsHuey)
As our Huey run balance tasks rely on Huey events to recored end time etc,
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/opt/rockstor/src/rockstor/storageadmin/tests/test_pool_balance_huey.py", line 138, in test_post_valid_balance_follow_through
    self.assertTrue(
AssertionError: False is not true : Expected pending Huey task id (072e3dd6-2bbd-4b70-9182-d71e23f4eb6d) not found

----------------------------------------------------------------------
Ran 278 tests in 30.441s

FAILED (failures=1)

However the above failure looks to be intermittent, as 5 consecutive re-runs results in:

----------------------------------------------------------------------
Ran 278 tests in 30.604s

OK

@phillxnet
Update Huey task queue library rockstor#2731
1ba450c 
Remove prior pin of 2.3.0 and update to 2.5.0 via
`poetry update` to recreate poetry.lock accordingly.
@phillxnet phillxnet marked this pull request as draft November 11, 2023 18:45
@phillxnet phillxnet marked this pull request as ready for review November 11, 2023 18:54
@phillxnet
Copy link
Member Author

phillxnet commented Nov 13, 2023 •
edited
Loading

@FroggyFlox Give you have successfully built an RPM with this PR pre-merged and I've just done the same here, along with a repeat test of netdata rock-on install - run - stop - uninstall. I'll go ahead and merge this to press on with our technical dept main objective.

[13/Nov/2023 17:18:41] INFO [storageadmin.views.rockon:505] Rock-on definitions retrieved in: 6.30 seconds.
[13/Nov/2023 17:19:51] INFO [storageadmin.tasks:56] Now executing Huey task [install], id: 52dae8c1-19c4-4e49-85f7-f6d8c1bf4c51.
[13/Nov/2023 17:19:51] ERROR [system.osi:261] non-zero code(1) returned by command: ['/usr/bin/docker', 'stop', 'netdata_official']. output: [''] error: ['Error response from daemon: No such container: netdata_official', '']
[13/Nov/2023 17:19:51] ERROR [system.osi:261] non-zero code(1) returned by command: ['/usr/bin/docker', 'rm', 'netdata_official']. output: [''] error: ['Error response from daemon: No such container: netdata_official', '']
[13/Nov/2023 17:20:02] INFO [storageadmin.views.rockon:107] Rockon (Netdata (official)) state pending and no pending task: assuming task is mid execution.
[13/Nov/2023 17:20:15] INFO [storageadmin.tasks:64] Task [install], id: 52dae8c1-19c4-4e49-85f7-f6d8c1bf4c51 completed OK

and

rleap15-5:/opt/rockstor # poetry show --tree | grep huey
huey 2.5.0 huey, a little task queue

@phillxnet phillxnet merged commit b328aaa into rockstor:testing Nov 13, 2023
@phillxnet phillxnet deleted the 2731-Update-Huey-task-queue-library branch November 13, 2023 17:30
@phillxnet phillxnet mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phillxnet