Clear InputMethodManager.sInstance for SDK > P #6880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a minor case of test pollution when a test interacts with a TextView. InputMethodManager.sInstance still gets populated in SDK > P, and it may contain a reference to a ViewRootImpl (mCurRootView), which causes an Activity to leak across tests. PiperOrigin-RevId: 411153919
f0d451b to
5a1f02a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear InputMethodManager.sInstance for SDK > P
This fixes a minor case of test pollution when a test interacts with a
TextView.
InputMethodManager.sInstance still gets populated in SDK > P, and it may
contain a reference to a ViewRootImpl (mCurRootView), which causes an Activity
to leak across tests.