Skip to content

Migrate useLegacy and JUnit assumeTrue/False to TruthJUnit assme #8149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2023
Merged

Migrate useLegacy and JUnit assumeTrue/False to TruthJUnit assme #8149

merged 1 commit into from
May 1, 2023

Conversation

@utzcoz
Copy link
Member

@utzcoz utzcoz commented Apr 16, 2023

Fixes: #7689.

@utzcoz
Copy link
Member Author

utzcoz commented Apr 16, 2023

@hoisie Should we prefer to org.junit.Assume.assumeTrue/False or com.google.common.truth.TruthJUnit.assume?

@utzcoz utzcoz requested a review from hoisie April 16, 2023 14:55
@hoisie
Copy link
Contributor

hoisie commented Apr 17, 2023

I tend to use com.google.common.truth.TruthJUnit.assume

@utzcoz
Copy link
Member Author

utzcoz commented Apr 17, 2023

I tend to use com.google.common.truth.TruthJUnit.assume

Okay. I will do a convertion from JUnit's one to TruthJunit with this PR this weekend.

@utzcoz utzcoz force-pushed the migrate-useLegacy branch from 7d6bd9b to 34f4174 Compare April 22, 2023 09:19
@utzcoz utzcoz changed the title Migrate useLegacy to assumeTrue/False for some tests Migrate useLegacy and JUnit assumeTrue/False to TruthJUnit assme Apr 22, 2023
@utzcoz utzcoz force-pushed the migrate-useLegacy branch from 34f4174 to 5db6f6a Compare April 22, 2023 09:22
@utzcoz
Copy link
Member Author

utzcoz commented Apr 22, 2023

@hoisie Updated. PTAL.

@utzcoz utzcoz requested a review from brettchabot April 24, 2023 09:43
@utzcoz
Copy link
Member Author

utzcoz commented Apr 27, 2023

@hoisie Friendly ping for reviewing.

@utzcoz
Migrate useLegacy and JUnit assumeTrue/False to TruthJUnit assume
8bf3b8a 
Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz force-pushed the migrate-useLegacy branch from 5db6f6a to 8bf3b8a Compare May 1, 2023 01:24
@utzcoz utzcoz merged commit 539971c into robolectric:master May 1, 2023
@utzcoz utzcoz deleted the migrate-useLegacy branch May 1, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoisie hoisie Awaiting requested review from hoisie

@brettchabot brettchabot Awaiting requested review from brettchabot

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate if statement with useLegacy() to assumeTrue/assumeFalse

2 participants

@utzcoz @hoisie