Use Bitmap.copyPixelsFromBuffer to copy image data ImageReader in HW rendering #8988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fc2d5f0 to
dbb8be7
Compare
…rendering When HardwareRenderer is used, the underlying Bitmap data is stored as premultiplied alpha. Previously, when that data is copied to an Android Bitmap object, Bitmap.setPixels was used, which assumed the int array passed was un-premultiplied data. Update to use Bitmap.copyPixelsFromBuffer, which does not make any assumptions about the underlying data. By default Android bitmaps are stored as premultiplied alpha. This fixes an issue with alpha blending in HW rendering. PiperOrigin-RevId: 624739361
dbb8be7 to
c0c8e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Bitmap.copyPixelsFromBuffer to copy image data ImageReader in HW rendering
When HardwareRenderer is used, the underlying Bitmap data is stored as
premultiplied alpha. Previously, when that data is copied to an Android Bitmap
object, Bitmap.setPixels was used, which assumed the int array passed was
un-premultiplied data. Update to use Bitmap.copyPixelsFromBuffer, which does
not make any assumptions about the underlying data. By default Android bitmaps
are stored as premultiplied alpha.
This fixes an issue with alpha blending in HW rendering.