Throws RuntimeException with more accurate error message if buildActivity passed class is abstract #9085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
approved these changes
May 19, 2024
8f53304 to
1f7ca37
Compare
|
New commit switches to throw RuntimeException with more accurate reason to follow ActivityScenario#launch result on Emulator. |
|
cc @david-allison , please help to check whether this error message can meet your requirement. |
MGaetan89
reviewed
May 19, 2024
integration_tests/ctesque/src/sharedTest/java/android/app/ActivityTest.java
Show resolved
Hide resolved
robolectric/src/test/java/org/robolectric/shadows/ShadowActivityTest.java
Outdated
Show resolved
Hide resolved
testapp/src/main/java/org/robolectric/testapp/AbstractTestActivity.java
Outdated
Show resolved
Hide resolved
1f7ca37 to
90216d4
Compare
Follow up the result of `ActivityScenario#launch` with abstract Activity class, but Robolectric provides a different error message to let developers know the real reason is the Activity class is abstract. Signed-off-by: utzcoz <utzcoz@outlook.com>
90216d4 to
1c2491d
Compare
david-allison
approved these changes
May 19, 2024
|
@david-allison Yeah. Two different Activity are used for different test suite. Thanks for your confirmation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #8997.