Return the correct value in ViewConfiguration.getScaledMinimumScalingSpan #9018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Span
Previously, Robolectric was returning an incorrect value ('0') when
ViewConfiguration.getScaledMinimumScalingSpan was called. This affects
calculations when triggering pinch-and-spread-to-zoom actions.
The real value is defined as '27mm' by default and '32mm' for large
screen devices.
Also add a transient, short-lived system property to allow tests to opt-in
to the incorrect behavior.
PiperOrigin-RevId: 627074303
d1265cd to
cf26305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the correct value in ViewConfiguration.getScaledMinimumScalingSpan
Previously, Robolectric was returning an incorrect value ('0') when
ViewConfiguration.getScaledMinimumScalingSpan was called. This affects
calculations when triggering pinch-and-spread-to-zoom actions.
The real value is defined as '27mm' by default and '32mm' for large
screen devices.
Also add a transient, short-lived system property to allow tests to opt-in
to the incorrect behavior.