@MGaetan89 Please check CI logs to check whether there are extra adaption we need to do for this PR. Thanks.

@MGaetan89 Please rebase your PR based on latest master branch as I merged some commits to make CI green.

@MGaetan89 Please rebase your PR based on latest master branch as I merged some commits to make CI green.

Done. I'll check the remaining failures this weekend.

@MGaetan89 I think you can reproduce them locally and fix them.

@utzcoz @hoisie the Tests / build step failed because of an out of memory error. Could either of you please restart it?

Caused by: java.lang.RuntimeException: java.lang.OutOfMemoryError: Java heap space

@MGaetan89 Please rebase and we can check whether it can merged now.

@MGaetan89 Please rebase and we can check whether it can merged now.

Done. Looks like there are still some failing tests. I'm investigating now

I recommend you to run these tests locally to ensure they can all pass as this PR changes a lot of code before pushing again.

@utzcoz I fixed the tests in ShadowContextImplTest, but there seem to be a memory issue now. Could you restart the failing job please?

Also, I noticed that testapp is the only module left with minSdk set to 19. Should I bump it to 21?

Also, I noticed that testapp is the only module left with minSdk set to 19. Should I bump it to 21?

@MGaetan89 I think yes. But you can open a new PR to cleanup.

We're getting closer!
Now it's the emulator that failed to start 😅

Error: Timeout waiting for emulator to boot.

I think it might be related to cache or Emulator. I deleted the cache, and tried it again.

Same result, and it happens as well in #9106

In the log, I see the following error message:

ERROR | Not enough space to create userdata partition. Available: 6957.617188 MB at /home/runner/.android/avd/../avd/test.avd, need 7372.800000 MB.

Since Linux runners have 14Gb of storage, maybe there are other caches taking up all the space?

@MGaetan89 In my opinion, other caches are necessary? Actually, SDK34 uses aosp_atd with a smaller disk usage.

  # As long as there are some space issues with the CI runners.

  - name: Free Disk Space
    uses: jlumbroso/free-disk-space@0add001504c51b93b35ac8e81d252bdd47e4ef07
    with:
      android: true
      dotnet: true
      haskell: true
      large-packages: true
      docker-images: true
      swap-storage: true
      tool-cache: false

@MGaetan89 What about integrating this action to freeup disk space by removing unused files bound by GitHub Action images?

Maybe another commit in this PR

Done in eac7f98

I'll squash my commits once the build is completed.

@MGaetan89 Please fix commit message warnings.

@utzcoz your suggestion seems to be working fine, thank you!
The downside is that it adds about 2min to each instrumentation test job. But we can investigate CI optimisation in a dedicated PR.

I've squashed my commits together, so the build should be successful soon 🤞🏻

@MGaetan89 Thanks. Maybe we need another PR to migrate test expected to assertThrows brought by this PR. This one LGTM. cc @brettchabot and @hoisie for this extra cleanup PR.