Skip to content

Conversation

@Devashishbasu
Copy link
Contributor

1.Converted instance fields to static fields to ensure proper state
management.
2.Add tests for the same in ShadowBatteryManagerTest 3.Add tests for BatteryManager instance behaviour across application and
activity contexts in ContextTest

Overview

Proposed Changes

@Devashishbasu Devashishbasu marked this pull request as draft July 9, 2024 16:02
@Devashishbasu Devashishbasu force-pushed the Make-fields-of-ShadowBatteryManager-static-for-context-level-instance branch from c4071b6 to 6dfe0f9 Compare July 9, 2024 18:02
1.Converted instance fields to static fields to ensure proper state
  management.
2.Add tests for the same in ShadowBatteryManagerTest
3.Add tests for BatteryManager instance behaviour across application and
  activity contexts in ContextTest
@Devashishbasu Devashishbasu force-pushed the Make-fields-of-ShadowBatteryManager-static-for-context-level-instance branch from 919e755 to 36b4519 Compare July 9, 2024 18:11
@Devashishbasu Devashishbasu marked this pull request as ready for review July 9, 2024 18:34
@Devashishbasu
Copy link
Contributor Author

Hi @utzcoz @hoisie, please review this PR, couldn't add a test for "batteryManager_activityContextEnabled_sharedState()" in ContextTest due to permission issue but added it in ShadowBatteryManagerTest

please let me know your feedback

@utzcoz utzcoz self-requested a review July 10, 2024 04:55
Copy link
Member

@utzcoz utzcoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Devashishbasu Thanks.

@utzcoz utzcoz merged commit 078a5f0 into robolectric:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants