uk_bin_collection/uk_bin_collection/councils/RushcliffeBoroughCouncil.py (2)

89-103: Two-date parsing logic is correct; small duplication and linter concerns

Functionally this does what you need: both dates are parsed and emitted as separate entries with the same type, so downstream consumers will see two upcoming collections per bin.

Two minor points you may want to tidy up:

1. Duplication – you could reduce repetition by looping over the two date fields instead of duplicating the append block, e.g.:

-        collection_one = datetime.strptime(result[1], "%d/%m/%Y")
-        data["bins"].append(
-            {
-                "type": result[0],
-                "collectionDate": collection_one.strftime(date_format),
-            }
-        )
-        collection_two = datetime.strptime(result[2], "%d/%m/%Y")
-        data["bins"].append(
-            {
-                "type": result[0],
-                "collectionDate": collection_two.strftime(date_format),
-            }
-        )
+        for raw_date in (result[1], result[2]):
+            collection = datetime.strptime(raw_date, "%d/%m/%Y")
+            data["bins"].append(
+                {
+                    "type": result[0],
+                    "collectionDate": collection.strftime(date_format),
+                }
+            )

2. Ruff F405 warnings – datetime and date_format are pulled in via from ...common import *, which is fine at runtime if common exports them, but static analysis tools complain. You could either:
   • Add explicit imports for clarity, e.g. from datetime import datetime at the top and import date_format explicitly from common, or
   • Add targeted # noqa: F405 comments on these uses if the star import pattern is intentional across the project.

---

105-109: Sorting after appending all bin entries is sensible; consider avoiding re-parsing

Deferring the sort until after all entries are appended is a good change and ensures a fully chronological list. Since you already normalise dates via strftime(date_format), you’re forced to re-parse here; if you ever switch to storing YYYY-MM-DD strings or keep a parallel datetime field, you could drop the extra strptime call. Not urgent, just a potential micro-optimisation.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro