object: add status.{phase,observedGeneration} to cephbn #16499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Hoblitt <josh@hoblitt.com>
BlaineEXE
approved these changes
Sep 22, 2025
Member
BlaineEXE
left a comment
There was a problem hiding this comment.
Changes look good. Rook historically hasn't put too much emphasis on statuses, including testing. With that in mind, I don't think anything more is needed.
Since you asked about testing status setting:
That has changed a little recently with the CephX key rotation work. Resources that rotate keys now have unit tests to ensure the cephx-specific status changes.
The CephCluster reconcile is the singular exception. That reconcile is complicated enough that e2e tests are needed to validate status for it, but I would expect other resources to validate status updates via unit tests so we can spare our e2e times.
6 tasks
subhamkrai
added a commit
that referenced
this pull request
Sep 23, 2025
object: add status.{phase,observedGeneration} to cephbn (backport #16499)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: