core: add support for ceph tentacle #16501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4a4479f to
4d19b7e
Compare
travisn
requested changes
Sep 17, 2025
| // Verify reading and writing to the test clients | ||
| newFile = "post-squid-upgrade-file" | ||
| s.verifyFilesAfterUpgrade(newFile, rbdFilesToRead, cephfsFilesToRead) | ||
| logger.Infof("Verified upgrade from reef to squid") |
Member
There was a problem hiding this comment.
We also need an upgrade test such as upgrade-from-tentacle-stable-to-tentacle-devel, similar to what was added for squid in #14454.
Member
There was a problem hiding this comment.
Looks like the github workflow update is also needed to trigger that test.
591fbcd to
b129932
Compare
travisn
requested changes
Sep 18, 2025
| // Verify reading and writing to the test clients | ||
| newFile = "post-squid-upgrade-file" | ||
| s.verifyFilesAfterUpgrade(newFile, rbdFilesToRead, cephfsFilesToRead) | ||
| logger.Infof("Verified upgrade from reef to squid") |
Member
There was a problem hiding this comment.
Looks like the github workflow update is also needed to trigger that test.
we are now adding tentacle to the supported versions and add the upgrade test from squid to tentacle. Also, clean some unused code. Signed-off-by: subhamkrai <srai@redhat.com>
b129932 to
11fac62
Compare
travisn
approved these changes
Sep 19, 2025
Member
travisn
left a comment
There was a problem hiding this comment.
When v20.2.0 (tentacle GA) is released, let's also plan on updating some of the PR CI tests to run tentacle, such as the smoke suite.
subhamkrai
added a commit
to subhamkrai/rook
that referenced
this pull request
Nov 21, 2025
These PR does the below changes - Added Tentacle test cases in `pkg/operator/ceph/version/version_test.go` - Updated `deploy/examples/cluster-test.yaml` to use v20 - Updated `deploy/examples/cluster.yaml` documentation to include Tentacle - Added Tentacle support note to `PendingReleaseNotes.md` Ceph tentacle was already added in PR rook#16501. Signed-off-by: subhamkrai <srai@redhat.com>
6 tasks
6 tasks
subhamkrai
added a commit
that referenced
this pull request
Nov 24, 2025
core: add support for ceph tentacle (backport #16501)
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Dec 3, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [rook-ceph-cluster](https://github.com/rook/rook) | patch | `v1.18.7` -> `v1.18.8` | --- ### Release Notes <details> <summary>rook/rook (rook-ceph-cluster)</summary> ### [`v1.18.8`](https://github.com/rook/rook/releases/tag/v1.18.8) [Compare Source](rook/rook@v1.18.7...v1.18.8) ### Improvements Rook v1.18.8 is a patch release limited in scope and focusing on feature additions and bug fixes to the Ceph operator. - core: Add support for ceph tentacle ([#​16501](rook/rook#16501), [@​subhamkrai](https://github.com/subhamkrai)) - helm: Include exporter options in CephCluster ([#​16745](rook/rook#16745), [@​michaeltchapman](https://github.com/michaeltchapman)) - toolbox: Merge rook-config-override ConfigMap into ceph.conf ([#​16731](rook/rook#16731), [@​mheler](https://github.com/mheler)) - csi: ControllerPlugin/NodePlugin resource settings were reversed ([#​16735](rook/rook#16735), [@​swills](https://github.com/swills)) - osd: Allow snaptrimp and snaptrip\_wait PGs by the PDBs during node drains ([#​16713](rook/rook#16713), [@​sp98](https://github.com/sp98)) - helm: Fix default pathType for HTTPRoute in the rook-ceph-cluster chart ([#​16724](rook/rook#16724), [@​fancl20](https://github.com/fancl20)) - pool: Retry if pool status is empty in the rados namespace controller ([#​16705](rook/rook#16705), [@​parth-gr](https://github.com/parth-gr)) - namespace: Add retryOnConflict when updating status ([#​16661](rook/rook#16661), [@​subhamkrai](https://github.com/subhamkrai)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41LjAiLCJ1cGRhdGVkSW5WZXIiOiI0Mi41LjAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImF1dG9tZXJnZSIsImNoYXJ0Il19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/2205 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we are now adding tentacle to the supported versions and add the upgrade test from squid to tentacle.
Issue resolved by this Pull Request:
Resolves #16747
Checklist: