core: fix ceph health check up status check (backport #16595) #16604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently the health checkup was reporting the condition and reason to be always connected, But which might not be the case, So instead of that dont report the condition and its phase during the health checkups Signed-off-by: parth-gr <partharora1010@gmail.com> (cherry picked from commit 454c221)
external mode was dependednt on the ceph status to update the cluster connected condition, BUt as now the status check will only update the ceph status, so we will explicitly update the ceph status condition in the end of the reconcile Signed-off-by: parth-gr <partharora1010@gmail.com> (cherry picked from commit 3f5ebe2)
travisn
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the health checkup was reporting the
condition and reason to be always connected,
But which might not be the case,
So instead of that dont report the condition and
its phase during the health checkups
Checklist:
This is an automatic backport of pull request #16595 done by [Mergify](https://mergify.com).