Skip to content

pool: retry if pool status is empty in rn controller (backport #16705) #16708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
travisn merged 2 commits into from
Nov 14, 2025
Merged

pool: retry if pool status is empty in rn controller (backport #16705) #16708

travisn merged 2 commits into from
Nov 14, 2025

Conversation

@mergify
Copy link

@mergify mergify bot commented Nov 12, 2025

if the pool is just created and getting the status updated rn controller can still go and proceed to
check the pool status
If the pool status is empty we should retry instead of proceeding further

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
This is an automatic backport of pull request #16705 done by [Mergify](https://mergify.com).

@mergify mergify bot added the conflicts label Nov 12, 2025
@mergify
Copy link
Author

mergify bot commented Nov 12, 2025

Cherry-pick of 7ef4b48 has failed:

On branch mergify/bp/release-1.18/pr-16705
Your branch is up to date with 'origin/release-1.18'.

You are currently cherry-picking commit 7ef4b4849.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   pkg/operator/ceph/pool/radosnamespace/controller.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@subhamkrai
Copy link
Contributor

subhamkrai commented Nov 13, 2025

@parth-gr PTAL

@parth-gr
Copy link
Member

parth-gr commented Nov 14, 2025

@Mergifyio rebase

@mergify
Copy link
Author

mergify bot commented Nov 14, 2025

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@parth-gr
Copy link
Member

parth-gr commented Nov 14, 2025

https://github.com/Mergifyio rebase

@mergify
Copy link
Author

mergify bot commented Nov 14, 2025 •
edited by parth-gr
Loading

rebase

☑️ Nothing to do, the required conditions are not met

Details
  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits > 1 [📌 rebase requirement]
    • #commits-behind > 0 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

@parth-gr
pool: retry if pool status is empty in rn controller
dd46974 
if the pool is just created and getting the status
updated rn controller can still go and proceed to
check the pool status
If the pool status is empty we should retry instead of
proceeding further

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit 7ef4b48)
Signed-off-by: parth-gr <partharora1010@gmail.com>
@parth-gr
subvolumegroup: retry if the filesystem status is empty in svg
81067f2 
if the filesystem is just created and getting the status
updated svg controller can still go and proceed to
check the filesystem status
If the filesystem status is empty we should retry instead of
proceeding further

Signed-off-by: parth-gr <partharora1010@gmail.com>
(cherry picked from commit fb72266)
@parth-gr parth-gr force-pushed the mergify/bp/release-1.18/pr-16705 branch from 58b4631 to 81067f2 Compare November 14, 2025 06:50
@parth-gr parth-gr requested a review from travisn November 14, 2025 06:50
@travisn travisn merged commit ff28766 into release-1.18 Nov 14, 2025
52 of 56 checks passed
@travisn travisn deleted the mergify/bp/release-1.18/pr-16705 branch November 14, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parth-gr parth-gr parth-gr approved these changes

@travisn travisn Awaiting requested review from travisn

Assignees

No one assigned

Labels

conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@subhamkrai @parth-gr @travisn