Drop Vagrant support #598
Drop Vagrant support #598
Conversation
| Don't include local env (useful for non-Lima users): | ||
| $ trellis alias --skip-local |
There was a problem hiding this comment.
Do you remember why is this useful? Not sure what the downside is for including local/dev all the time
There was a problem hiding this comment.
For Valet/other local dev envs since you just run wp commands without an alias
There was a problem hiding this comment.
Yeah but what's the point in even offering this option? Does it cause some issue you generated aliases for local/env without skipping it?
There was a problem hiding this comment.
If I remember it correctly, there were problems when both wp-cli.yml and wp-cli.trellis-alias.yml specific the same alias. The config get merged / overwritten in ways we didn't expect.
There was a problem hiding this comment.
👍 might as well just keep it then
| func (t *Trellis) SshHost(environment string, siteName string, user string) string { | ||
| host := t.SiteFromEnvironmentAndName(environment, siteName).MainHost() | ||
|
|
||
| if environment == "development" { |
There was a problem hiding this comment.
Ugh logs just never even worked on Lima. So this is fine anyway
This reverts commit 260a01f.
Ref roots/trellis#1622