Ability to filter content by golie clone#38
Merged
Conversation
isimluk
commented
Aug 17, 2020
Member
redhatrises
reviewed
Aug 18, 2020
| } | ||
| return nil | ||
| if !f.filtered(entry) { | ||
| log.Debugf("Skipping (filtered out) download of %s", entry.Link[0].Href) |
Contributor
There was a problem hiding this comment.
@isimluk what do we mean by "Skipping (filtered out) download" ? Are we only filtering on urls? If so, I am not sure that filtering is the right sub command name.
Member
Author
There was a problem hiding this comment.
We skip download of rolie entries that do not match the filter that is provided.
I am definitely open to use different language if you can propose such.
Contributor
There was a problem hiding this comment.
Don't have anything good especially since regex is used... so for now, filter it is!
redhatrises
reviewed
Aug 19, 2020
redhatrises
reviewed
Aug 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.