Skip to content

Add more known globals#4886

Draft
dnalborczyk wants to merge 5 commits into
rollup:masterfrom
dnalborczyk:known-globals
Draft

Add more known globals#4886
dnalborczyk wants to merge 5 commits into
rollup:masterfrom
dnalborczyk:known-globals

Conversation

@dnalborczyk

@dnalborczyk dnalborczyk commented Mar 1, 2023

Copy link
Copy Markdown
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@netlify

netlify Bot commented Mar 1, 2023

Copy link
Copy Markdown

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit 6fbee79
🔍 Latest deploy log https://app.netlify.com/sites/rollupjs/deploys/63fec14dfae8d0000812b6b4
😎 Deploy Preview https://deploy-preview-4886--rollupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov

codecov Bot commented Mar 1, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4886 (6fbee79) into master (1ab9833) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4886   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         219      219           
  Lines        7948     7948           
  Branches     2189     2189           
=======================================
  Hits         7867     7867           
  Misses         26       26           
  Partials       55       55           
Impacted Files Coverage Δ
src/ast/nodes/shared/knownGlobals.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dnalborczyk dnalborczyk marked this pull request as ready for review March 1, 2023 03:00
@dnalborczyk dnalborczyk marked this pull request as draft March 1, 2023 03:02
@lukastaegert

Copy link
Copy Markdown
Member

Any interest to follow up here?

@lukastaegert lukastaegert force-pushed the master branch 2 times, most recently from 5369863 to 96b5453 Compare November 7, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants