Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

馃悰 organizeImports saving in VSCode causes performance issue, CPU spinning聽#4757

Open
Open
馃悰 organizeImports saving in VSCode causes performance issue, CPU spinning#4757
Labels
S-Needs infoStatus: the issue needs more info in order to be triaged

Description

@jpike88
jpike88
opened on Aug 7, 2023

Environment information

CLI:
  Version:                      12.1.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  ROME_LOG_DIR:                 unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v16.14.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/8.5.0"

Rome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           true
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

Discovering running Rome servers...

Running Rome Server: 鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣鈹佲攣

What happened?

organiseImports works quickly via CLI but has major performance issues in VSCode if enabled on save, what seems like some kind of super inefficient or infinite loop with CPU maxed out endlessly.

Expected result

It should be fast

Code of Conduct

  • I agree to follow Rome's Code of Conduct

Activity

  1. jpike88
    added
    S-To triageStatus: user report of a possible bug that needs to be triaged
    on Aug 7, 2023

  2. ematipico commented on Aug 7, 2023

    @ematipico
    ematipico
    on Aug 7, 2023
    Contributor

    @jpike88 could please create a reproduction? Without a way for us to replicate the issue, it's absolutely impossible to help you.

  3. ematipico
    added
    S-Needs infoStatus: the issue needs more info in order to be triaged
    and removed
    S-To triageStatus: user report of a possible bug that needs to be triaged
    on Aug 7, 2023

  4. jpike88 commented on Aug 7, 2023

    @jpike88
    jpike88
    on Aug 7, 2023
    Author

    rome.json.zip

    also this may be useful (you need to re add the organize imports property on it though)

  5. jpike88 commented on Aug 8, 2023

    @jpike88
    jpike88
    on Aug 8, 2023
    Author

    Let me know when you have a window of time to recieve the file I'll comment with it

  6. ematipico commented on Aug 8, 2023

    @ematipico
    ematipico
    on Aug 8, 2023
    Contributor

    @jpike88 it's best to create a minimal repository with the code that triggers the issue.

  7. jpike88 commented on Aug 8, 2023

    @jpike88
    jpike88
    on Aug 8, 2023
    Author

    But the extension works on a file by file basis, wouldn't just giving a problem file do the job?

  8. jpike88 commented on Aug 8, 2023

    @jpike88
    jpike88
    on Aug 8, 2023
    Author

    ok fine ill do a minimal repo hold on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-Needs infoStatus: the issue needs more info in order to be triaged

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions