Skip to content

Just need to check the last byte.#89

Merged
rs merged 1 commit into
rs:masterfrom
robxyy:robx/check-rs/2022-10-09
Oct 9, 2022
Merged

Just need to check the last byte.#89
rs merged 1 commit into
rs:masterfrom
robxyy:robx/check-rs/2022-10-09

Conversation

@robxyy

@robxyy robxyy commented Oct 9, 2022

Copy link
Copy Markdown
Contributor

Refer: #71 #75

old:

go test -bench 'FromString*' -benchmem
goos: darwin
goarch: arm64
pkg: github.com/rs/xid
BenchmarkFromString-10    	445015340	         2.618 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/rs/xid	1.807s

new:

go test -bench 'FromString*' -benchmem
goos: darwin
goarch: arm64
pkg: github.com/rs/xid
BenchmarkFromString-10    	521384266	         2.304 ns/op	       0 B/op	       0 allocs/op
PASS
ok  	github.com/rs/xid	1.556s

@rs rs merged commit 1b855c3 into rs:master Oct 9, 2022
@kazk kazk mentioned this pull request Oct 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robxyy @rs