Skip to content

Implement vertical and opacity for noUiSlider filter #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shrektan merged 11 commits into from
Jul 8, 2021
Merged

Implement vertical and opacity for noUiSlider filter #919

shrektan merged 11 commits into from
Jul 8, 2021

Conversation

@alexvpickering
Copy link
Contributor

@alexvpickering alexvpickering commented Jun 20, 2021 •
edited
Loading

This adds a vertical and opacity option for filters and applies to the noUiSliders. I'm using this to implement DataTables with limited width that don't cause x overflow:

image

usage:

datatable(iris, filter = list(position = 'top', vertical=TRUE, opacity=0.85))

@CLAassistant
Copy link

CLAassistant commented Jun 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

yihui
yihui approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Please also add an item in NEWS.md and yourself as ctb to DESCRIPTION.

@shrektan Please feel free to merge if it looks good to you, too.

Thanks!

shrektan
shrektan requested changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@shrektan shrektan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@alexvpickering @shrektan
Update inst/htmlwidgets/datatables.js
b67f008 
Co-authored-by: Xianying Tan <shrektan@126.com>
@shrektan shrektan merged commit c49fb4d into rstudio:master Jul 8, 2021
@shrektan
Copy link
Collaborator

shrektan commented Jul 8, 2021

Thank you for this PR!

@shrektan shrektan added this to the v0.19 milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yihui yihui yihui approved these changes

@shrektan shrektan shrektan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.19

Development

Successfully merging this pull request may close these issues.

4 participants

@alexvpickering @CLAassistant @shrektan @yihui