Skip to content

Fix #348: All exercises resolve to complete when one is completed #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jcheng5 merged 2 commits into from
Jun 11, 2020
Merged

Fix #348: All exercises resolve to complete when one is completed #384

jcheng5 merged 2 commits into from
Jun 11, 2020

Conversation

@jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Jun 11, 2020 •
edited
Loading

Fixes #348.

Run the following, click the "Run Code" buttons one after another quickly. The progress spinner on both code chunks clear after 1 second, even though the two chunk doesn't complete for a few more seconds.

---
title: "Tutorial"
output: learnr::tutorial
runtime: shiny_prerendered
---

```{r setup, include=FALSE}
library(learnr)
```

```{r one, exercise=TRUE}
Sys.sleep(1); print("DONE!")
```

```{r two, exercise=TRUE}
Sys.sleep(5); print("DONE2!")
```

PR task list:

  • Update NEWS
  • Add tests (if possible)
  • Update documentation with devtools::document()

@jcheng5 jcheng5 marked this pull request as ready for review June 11, 2020 16:48
@jcheng5 jcheng5 requested a review from schloerke June 11, 2020 16:48
@jcheng5
Copy link
Member Author

jcheng5 commented Jun 11, 2020

Reviewed by @schloerke in person

@jcheng5 jcheng5 merged commit 9dfe4a9 into master Jun 11, 2020
@jcheng5 jcheng5 deleted the joe/bugfix/348-exercise-progress branch June 11, 2020 18:35
schloerke added a commit that referenced this pull request Jul 13, 2020
@schloerke
Merge branch 'master' into rmarkdown_smart
403558d 
* master:
  Fix #348: All exercises resolve to complete when one is completed (#384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schloerke schloerke Awaiting requested review from schloerke

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

All exercises resolve to complete when one is completed

2 participants

@jcheng5