Skip to content

ROX-32170: Add user and rbac authrization #18263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
c-du wants to merge 4 commits into
base: master
Choose a base branch
from
Open

ROX-32170: Add user and rbac authrization #18263

c-du wants to merge 4 commits into from
+234 −29

Conversation

@c-du
Copy link
Contributor

@c-du c-du commented Dec 17, 2025

Description

  1. Add created_by user to proto
  2. Make changes to base image store and data store.
  3. Change the resource of base image to ImageAdministration in datastore.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@c-du c-du requested a review from a team as a code owner December 17, 2025 07:02
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Dec 17, 2025 •
edited
Loading

Images are ready for the commit at 95c12e4.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-626-g95c12e477b.

@codecov
Copy link

codecov bot commented Dec 17, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.16%. Comparing base (f3d21b6) to head (c08aa27).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...l/baseimage/datastore/repository/datastore_impl.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #18263   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files        2739     2739           
  Lines      201222   201235   +13     
=======================================
+ Hits        98924    98938   +14     
  Misses      94595    94595           
+ Partials     7703     7702    -1
Flag Coverage Δ
go-unit-tests 49.16% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@c-du c-du requested review from jvdm and ksurabhi91 December 17, 2025 18:15
jvdm
jvdm reviewed Dec 17, 2025
View reviewed changes
central/baseimage/datastore/repository/datastore_impl_test.go
mockID.EXPECT().FriendlyName().Return("name").AnyTimes()
s.mockID = mockID

ctx := sac.WithGlobalAccessScopeChecker(context.Background(),
Copy link
Contributor

@jvdm jvdm Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ctx := sac.WithGlobalAccessScopeChecker(context.Background(),
ctx := sac.WithGlobalAccessScopeChecker(s.T().Context(),

@openshift-ci
Copy link

openshift-ci bot commented Dec 17, 2025

@c-du: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-nongroovy-e2e-tests 95c12e4 link false /test ocp-4-12-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvdm jvdm jvdm left review comments

@ksurabhi91 ksurabhi91 Awaiting requested review from ksurabhi91

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/central area/postgres

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-du @rhacs-bot @jvdm